Feat: 1640 add remaining gtfs features to the validator#1656
Feat: 1640 add remaining gtfs features to the validator#1656
Conversation
…lidator # Resolved Conflicts: # main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@qcdyx Nice work! Two comments:
- I don't see
Pathways (extra)when I test with MBTA's feed - I now get a
agency.txt. INVALID_HEADERSerror when I run the validator through the cli. This is making the agency column in the Summary report empty even when the agency is provided by the feed (which I can also see in your screenshot). I don't see this in our staging environment, so I'm wondering if this is introducing a new bug.
|
@qcdyx A requirement change: Transfer Rules should be renamed "Transfer Fares" |
|
❌ Invalid acceptance test. |
|
❌ Invalid acceptance test. |
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Show resolved
Hide resolved
I expected no changes in the acceptance tests as #1640 tasks only relate to adding component information to the HTML and JSON formatting. Is it related to ? |
main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsNetworkSchema.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsNetworkSchema.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsNetworkSchema.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FareAttributeAgencyIdValidator.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/mobilitydata/gtfsvalidator/validator/MatchingFeedAndAgencyLangValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/RouteAgencyIdValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/UrlConsistencyValidator.java
Outdated
Show resolved
Hide resolved
|
@qcdyx Additional changes to scope (could make a new issue/PR for this one): Remove the following base components:
|
|
@emma just fixed the agency problem |
|
@qcdyx Rename Pathways to Pathways (basic) |
changed loadPathwayExtraComponent logic
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
…where we can test it in isolation.
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Outdated
Show resolved
Hide resolved
|
@davidgamez I've made the changes and commented GtfsNetworkSchema code. I'll uncommented the code and remove the requested components in a new PR once this is merged. |
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Outdated
Show resolved
Hide resolved
Thanks @qcdyx , Can you kindly remove the commented code from the PR? |
|
✅ Rule acceptance tests passed. |
|
@qcdyx @davidgamez The example feeds all run correctly - only thing I notice is that Route Names hasn't been deleted. I'll let @jcpitre do the final review + merge :) |
|
@emmambd I have the route name deletion code locally. I'll commit it in a new PR together with GtfsNetworkSchema. |




Summary:
Added new GTFS features as described in #1640
Expected behavior:


MBTA.zip
Bullrunner.zip
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything