You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running the validator with multiple datasets (like in the web validator) we sometimes have errors in the results because the noticeContainer is shared between threads.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with gradle test to make sure you didn't break anything
✅ Rule acceptance tests passed.
New Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
2 out of 1479 sources (~0 %) are corrupted.
Corrupted sources:
ci-abidjan-divers-operateurs-gtfs-913
de-unknown-verkehrsverbund-stuttgart-gtfs-1089
Commit: 0576629
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.
The problem repaired in this in PR happened only if the validator is processing more than one dataset at the same time.
Normally this would warrant a maintenance release, since the web validator just did not work many times, but we can apply a stopgap measure instead. For the web validator we changed the configuration to allow only 1 simultaneous request per instance, meaning there is no risk of multithread problems between validation of different feeds.
We can go back with multiple requests after the next release is deployed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jcpitre
deleted the
1647-feed-displaying-different-validation-reports-when-re-run
branch
Summary:
Closes #1647
When running the validator with multiple datasets (like in the web validator) we sometimes have errors in the results because the noticeContainer is shared between threads.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything