refactor: Replace CurrentDateTime with DateForValidation and use LocalDate#1636
Conversation
… type from ZonedDateTime to LocalDate
|
Let's complicate things a bit ;) |
|
It's easy to support a timezone with the changes in this PR (and also with the existing code). The date is set with LocalDate.now(), but there is another form of the method now() that takes a timezone (ZoneID). Since timezone is required in the feed, it seems straightforward. I expect the only challenge there will be dealing with improper timezone entries. But that should be in a separate PR from this refactor, since it is a change in behavior. |
jcpitre
left a comment
jcpitre
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks
… type from ZonedDateTime to LocalDate
…r/gtfs-validator into date-for-validation Trying to update based on other changes to the master branch.
|
I tried to add in updates (not mine) that had been made to the "master" branch, but I may have done it incorrectly. Could someone let me know if I need to change anything before this can be merged? |
Hi, @bradyhunsaker; it looks like the code formatting check is failing on your branch. As soon as fixed, we can merge it. |
|
I just pushed a commit that was the result of running the Java formatter. I should have run it before my original push. |
3 participants
Summary:
Preparation to make PR #1628 for issue #1292 clearer.
Several rules compare dates in the feed to a reference date, which is usually today. The object that stores the date is called CurrentDateTime and it wraps a ZonedDateTime object. But only the date is ever used (not the time), and the date can be overridden in tests to use specific dates other than today.
This refactor renames the object DateForValidation and wraps a LocalDate object instead. This simplifies the code in several places and will allow PR #1628 to be clearer.
Expected behavior:
No change in behavior. Internally a LocalDate will be used instead of a ZonedDateTime.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything