Skip to content

fix: validator version displayed in validator report summary#1627

Merged
jcpitre merged 3 commits intomasterfrom
1620-fix-validator-version-displayed-in-validator-report-summary
Dec 22, 2023
Merged

fix: validator version displayed in validator report summary#1627
jcpitre merged 3 commits intomasterfrom
1620-fix-validator-version-displayed-in-validator-report-summary

Conversation

@jcpitre
Copy link
Copy Markdown
Contributor

@jcpitre jcpitre commented Dec 21, 2023

Summary:

Fixes #1620
the problem was that we were using the same Docker image for staging and prod.
Configured so the staging Docker image has a different name than the production one.

Expected behavior:
After executing the web_svc_pr.yml github action, tested that:

Please make sure these boxes are checked before submitting your pull request - thanks!

@jcpitre jcpitre linked an issue Dec 21, 2023 that may be closed by this pull request
@jcpitre jcpitre requested a review from davidgamez December 21, 2023 20:31
Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcpitre jcpitre merged commit 3d5ef6f into master Dec 22, 2023
@jcpitre jcpitre deleted the 1620-fix-validator-version-displayed-in-validator-report-summary branch December 22, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix validator version displayed in validator report summary

2 participants