fix: cypress error scenario on downloading rules definitions file#1617
Merged
davidgamez merged 2 commits intomasterfrom Nov 27, 2023
Merged
fix: cypress error scenario on downloading rules definitions file#1617davidgamez merged 2 commits intomasterfrom
davidgamez merged 2 commits intomasterfrom
Conversation
davidgamez
commented
Nov 27, 2023
Comment on lines
-125
to
-127
| cy.get('a') | ||
| .should('contain.text', 'https://github.com/MobilityData/gtfs-validator/blob/master/RULES.md') | ||
| .and('have.attr', 'href', 'https://github.com/MobilityData/gtfs-validator/blob/master/RULES.md'); |
Member
Author
There was a problem hiding this comment.
This content was removed from the page
davidgamez
commented
Nov 27, 2023
| cy.get('a') | ||
| .should('contain.text', 'https://github.com/MobilityData/gtfs-validator/blob/master/RULES.md') | ||
| .and('have.attr', 'href', 'https://github.com/MobilityData/gtfs-validator/blob/master/RULES.md'); | ||
| cy.get('p').should('contain.text', 'There was a problem loading the rules file.'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Summarize the changes in the pull request, including how it relates to any issues (include the #number, or link them).
Expected behavior:
Cypress integration tests are failing due to changes in the page structure in the latest release. This PR fixes the test, updating it with the latest expected web structure.
rules.htmlimplementationOut of scope:
Part of #1616
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything