fix: Package installers CI step failing #1568
Conversation
|
Screenshot of the downloaded app showing properly notarized. Look for text |
|
✅ Rule acceptance tests passed. |
2 participants
{{ message }}
Merged
davidgamez merged 8 commits intomasterfrom Sep 12, 2023
Merged
Member
Author
fredericsimard
approved these changes
Sep 12, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As described in #1567, the Github actions associated with the MacOS certificate imports, notarization, and stapling were dependent on open-source projects that are not available anymore. This PR implements the MacOS certificate imports, notarization, and stapling using XCode terminal commands.
Fixes #1567
Expected behavior:
GTFS Validator App is signed and notarized.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything