Skip to content

feat: 1520 gtfs validator desktop app deprecation#1555

Merged
davidgamez merged 15 commits intomasterfrom
1520-gtfs-validator-desktop-app-deprecation
Sep 13, 2023
Merged

feat: 1520 gtfs validator desktop app deprecation#1555
davidgamez merged 15 commits intomasterfrom
1520-gtfs-validator-desktop-app-deprecation

Conversation

@qcdyx
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx commented Aug 8, 2023

Summary:
Closes #1520

Expected behavior:

image

Please make sure these boxes are checked before submitting your pull request - thanks!

@qcdyx qcdyx requested a review from davidgamez August 8, 2023 18:34
@qcdyx qcdyx linked an issue Aug 8, 2023 that may be closed by this pull request
qcdyx and others added 2 commits August 8, 2023 15:35
…ervice/controller/ValidationController.java

Co-authored-by: David Gamez <[email protected]>
…ervice/controller/ValidationController.java

Co-authored-by: David Gamez <[email protected]>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 9, 2023

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 9, 2023

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 9, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: b4c2c92
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx qcdyx requested a review from davidgamez August 10, 2023 11:37
@davidgamez davidgamez requested a review from bdferris-v2 August 10, 2023 14:03
@github-actions
Copy link
Copy Markdown
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: c8b2af2
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: 545febb
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1470 sources (~0 %) are corrupted.
Commit: 4cd5716
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez merged commit cf7e96d into master Sep 13, 2023
@davidgamez davidgamez deleted the 1520-gtfs-validator-desktop-app-deprecation branch September 13, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GTFS-Validator Desktop App Deprecation

3 participants