Skip to content

feat: add stop_id to the decreasing_or_equal_stop_time_distance notice#1554

Merged
davidgamez merged 1 commit intomasterfrom
feat/1547
Aug 8, 2023
Merged

feat: add stop_id to the decreasing_or_equal_stop_time_distance notice#1554
davidgamez merged 1 commit intomasterfrom
feat/1547

Conversation

@cka-y
Copy link
Copy Markdown
Contributor

@cka-y cka-y commented Aug 8, 2023

Summary:
Added stop_id after trip_id in the notice details of decreasing_or_equal_stop_time_distance.
Closes #1547

Expected behavior:
The stop_id field is included in the notice details.

Please make sure these boxes are checked before submitting your pull request - thanks!

@cka-y cka-y requested review from isabelle-dr and qcdyx August 8, 2023 14:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 8, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: e16c8d1
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

qcdyx
qcdyx approved these changes Aug 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidgamez davidgamez merged commit 719b522 into master Aug 8, 2023
@davidgamez davidgamez deleted the feat/1547 branch August 8, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidgamez davidgamez davidgamez approved these changes

@qcdyx qcdyx qcdyx approved these changes

@isabelle-dr isabelle-dr Awaiting requested review from isabelle-dr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add stop_id to the decreasing_or_equal_stop_time_distance notice

3 participants

@cka-y @davidgamez @qcdyx