Skip to content

fix: decreasing_or_equal_stop_time_distance#1548

Closed
isabelle-dr wants to merge 3 commits intomasterfrom
fix-bug-decreasing-or-equal-stop-time-distance-notice
Closed

fix: decreasing_or_equal_stop_time_distance#1548
isabelle-dr wants to merge 3 commits intomasterfrom
fix-bug-decreasing-or-equal-stop-time-distance-notice

Conversation

@isabelle-dr
Copy link
Copy Markdown
Contributor

@isabelle-dr isabelle-dr commented Aug 1, 2023

Summary:

Found a bug as I opened #1547.

For the decreasing_or_equal_stop_time_distance notice, it should be prevShapeDistTraveled and not prevStopTimeDistTraveled in the notice details.

Expected behavior:
The notice details have prevShapeDistTraveled instead of prevStopTimeDistTraveled.

  • Before:
Screenshot 2023-08-01 at 6 30 29 PM
  • After:

Please make sure these boxes are checked before submitting your pull request - thanks!

@isabelle-dr
Copy link
Copy Markdown
Contributor Author

This seems to be more complex than what I've initially thought (maybe even on purpose?), closing this PR for more investigation 🦝

@isabelle-dr isabelle-dr closed this Aug 1, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 1, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: c96a3d8
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant