feat: 1423 only warn if feed contact email or url are both unset by qcdyx · Pull Request #1514 · MobilityData/gtfs-validator

qcdyx · 2023-06-27T15:26:07Z

Summary:

Close #1423
Only give a warning when both feed_contact_email and feed_contact_url are unset.
The screenshot uses the akocity_with_email.zip dataset. The feed_info.txt only contains feed_contact_email but doesn't contain feed_contact_url, the screenshot shows that the report does not generate a missing_recommended_field warning.

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with gradle test to make sure you didn't break anything
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)

add hasFeedContactEmailAndUrlShouldNotGenerateNotice test method add method comments

main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FeedContactValidator.java

github-actions · 2023-06-27T15:58:01Z

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 202 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 43ff5cb
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

…cumentationTest errors

github-actions · 2023-06-27T18:22:16Z

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 202 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 66f5efb
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

…l-are-both-unset # Resolved Conflicts: # RULES.md

github-actions · 2023-06-28T14:18:21Z

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 203 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 7af9ddd
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

github-actions · 2023-06-28T14:28:37Z

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 203 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 7af9ddd
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

…l or empty in the case of MissingFeedContactEmailAndUrlNotice

github-actions · 2023-06-28T16:48:58Z

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 203 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: e83bc70
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

qcdyx · 2023-06-29T19:50:42Z

I got 1 failing Rule acceptance test, but it's expected by design.

The 425 new warnings: I create a new FeedContactEmailAndUrlNotice to check if both feed_contact_email and feed_contact_url are unset, we are aiming for new warnings to be discovered.
The 203 dropped warnings: the @recommended annotations are removed from feedContactEmail() and feedContactUrl() on purpose so that the new FeedContactValidator class takes charge of the validation.
Therefore, this PR is ready to be merged.

davidgamez

🚀

…l-are-both-unset

github-actions · 2023-06-29T20:59:33Z

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 202 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: ae3032f
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

qcdyx added 6 commits June 22, 2023 14:22

create FeedContactValidator class

9de5677

create FeedContactValidatorTest class

907930f

add 4 tests

fb2d595

add nonFeedContactEmailAndUrlShouldGenerateNotice test

134a203

format code

be26287

add hasFeedContactEmailAndUrlShouldNotGenerateNotice test method add method comments

remove the @recommended annotation from GtfsFeedInfoSchema

e7fdce3

qcdyx changed the title ~~1423 only warn if feed contact email or url are both unset~~ feat: 1423 only warn if feed contact email or url are both unset Jun 27, 2023

davidgamez reviewed Jun 27, 2023

View reviewed changes

main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FeedContactValidator.java Outdated Show resolved Hide resolved

qcdyx added 3 commits June 27, 2023 12:21

add comments to fix org.mobilitydata.gtfsvalidator.validator.NoticeDo…

e264cdd

…cumentationTest errors

add comments to fix NoticeFieldsTest

88e132a

format code

d320958

qcdyx added 2 commits June 27, 2023 16:45

update RULES.md to fix broken tests

b7e9a8e

Merge branch 'master' into 1423-Only-warn-if-feed_contact_email-or-ur…

cfe33b4

…l-are-both-unset # Resolved Conflicts: # RULES.md

remove "feedContactEmail" and "feedContactUrl" as they are either nul…

d078119

…l or empty in the case of MissingFeedContactEmailAndUrlNotice

qcdyx mentioned this pull request Jun 29, 2023

Issue/1423/only warn both unset #1434

Closed

4 tasks

davidgamez approved these changes Jun 29, 2023

View reviewed changes

Merge branch 'master' into 1423-Only-warn-if-feed_contact_email-or-ur…

ccb166d

…l-are-both-unset

davidgamez merged commit 18051a6 into master Jun 29, 2023

davidgamez deleted the 1423-Only-warn-if-feed_contact_email-or-url-are-both-unset branch June 29, 2023 21:06

davidgamez pushed a commit that referenced this pull request Jul 5, 2023

feat: 1423 only warn if feed contact email or url are both unset (#1514)

7a53f57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 1423 only warn if feed contact email or url are both unset#1514

feat: 1423 only warn if feed contact email or url are both unset#1514
davidgamez merged 13 commits intomasterfrom
1423-Only-warn-if-feed_contact_email-or-url-are-both-unset

qcdyx commented Jun 27, 2023 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Jun 27, 2023

Uh oh!

github-actions bot commented Jun 27, 2023

Uh oh!

github-actions bot commented Jun 28, 2023

Uh oh!

github-actions bot commented Jun 28, 2023

Uh oh!

github-actions bot commented Jun 28, 2023

Uh oh!

qcdyx commented Jun 29, 2023 •

edited

Loading

Uh oh!

davidgamez left a comment

Uh oh!

github-actions bot commented Jun 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

qcdyx commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 27, 2023

Uh oh!

github-actions bot commented Jun 27, 2023

Uh oh!

github-actions bot commented Jun 28, 2023

Uh oh!

github-actions bot commented Jun 28, 2023

Uh oh!

github-actions bot commented Jun 28, 2023

Uh oh!

qcdyx commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidgamez left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

qcdyx commented Jun 27, 2023 •

edited

Loading

qcdyx commented Jun 29, 2023 •

edited

Loading