Skip to content

feat: Provide an explanation to users about what a GTFS Component is #1505#1512

Merged
cka-y merged 2 commits intomasterfrom
issue/1505
Jun 26, 2023
Merged

feat: Provide an explanation to users about what a GTFS Component is #1505#1512
cka-y merged 2 commits intomasterfrom
issue/1505

Conversation

@cka-y
Copy link
Copy Markdown
Contributor

@cka-y cka-y commented Jun 26, 2023 •
edited
Loading

Summary:

The GTFS Component now has a description to help the user understand its value.
The summary section is as wide as the compliance report.

Expected behavior:
image

Closes #1505
Closes #1467

Also fixes missing summary section for notices and missing description for the notice's fields.
Before:
image

With the changes:
image

Please make sure these boxes are checked before submitting your pull request - thanks!

davidgamez
davidgamez approved these changes Jun 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cka-y cka-y merged commit d9c1ecb into master Jun 26, 2023
@cka-y cka-y deleted the issue/1505 branch June 26, 2023 19:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 26, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: c2d32a1
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

davidgamez pushed a commit that referenced this pull request Jul 5, 2023
@cka-y @davidgamez
feat: Provide an explanation to users about what a GTFS Component is #…
4d324a3 
…1505 (#1512)

* fix: display tooltip text

* feat: gtfs component description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidgamez davidgamez davidgamez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide an explanation to users about what a GTFS Component is Summary Section as wide as the Specification Compliance report section

2 participants

@cka-y @davidgamez