feat: validator for ferry trips + bikes allowance#1510
Conversation
|
❌ Invalid acceptance test. |
|
Thank you for working on this! |
|
@davidgamez, does this PR have any dependencies with the automatic generation of documentation? |
|
❌ Invalid acceptance test. |
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
|
❌ Invalid acceptance test. |
|
@cka-y I think it would be worthwhile to verify that the failing acceptance tests are consistant with the change in the code and were expected. |
|
Since we introduced a new warning notice, some acceptance tests are failing. |
|
❌ Invalid acceptance test. |
* feat: validator for ferry trips + bike allocation * feat: removed "info" suffix * feat: fixed formatting
Summary:
Add a rule with a WARNING severity level that checks is bike_allowed is present for ferry trips, after the addition in MobilityData/GTFS_Schedule_Best-Practices#55.
Closes #1499
Expected behavior:
missing_bike_allowance warning notice is added to the report if ferry route types don't specify the bikes_allowed value. Valid values are 1 (bikes allowed) and 2 (bikes not allowed). Any value different from 1 or 2 will result in the warning being present in the report.
gradle testto make sure you didn't break anything