feat: 1465 add a route colors gtfs component#1492
Conversation
…es if return true
|
Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:
|
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
|
✅ Rule acceptance tests passed. |
|
✅ Rule acceptance tests passed. |
|
Summary: Expected behavior: Please make sure these boxes are checked before submitting your pull request - thanks!
|
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
1 similar comment
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
|
✅ Rule acceptance tests passed. |
| ImmutableList.of(GtfsRouteTableDescriptor.class, GtfsAgencyTableDescriptor.class)); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Good job on the comments explaining the tests.
There was a problem hiding this comment.
Thank you! I like writing comments - make newcomers less confused!
|
✅ Rule acceptance tests passed. |


Close #1465
wrote logic and unit tests for Adding a "Route Colors" component - it's present if both the fields route_color and route_text_color in routes.txt are present, and if they have at least one value defined.