Skip to content

Feat: Remove SeverityLevel from ValidationNotice constructor#1489

Merged
davidgamez merged 7 commits intomasterfrom
issue/1472/severity_level
Jun 6, 2023
Merged

Feat: Remove SeverityLevel from ValidationNotice constructor#1489
davidgamez merged 7 commits intomasterfrom
issue/1472/severity_level

Conversation

@bdferris-v2
Copy link
Copy Markdown
Collaborator

Closes #1472.

Cleans up ValidationNotice(SeverityLevel) constructor calls, as SeverityLevel is now read from the @GtfsValidationNotice annotation.

Please make sure these boxes are checked before submitting your pull request - thanks!

@bdferris-v2 bdferris-v2 requested a review from davidgamez June 6, 2023 21:06
@davidgamez
Copy link
Copy Markdown
Member

davidgamez commented Jun 6, 2023

Hi @bdferris-v2 , can we update the documentation located on NEW_RULES.md part of this PR?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 6, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: 969a050
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@bdferris-v2
Copy link
Copy Markdown
Collaborator Author

@davidgamez done

Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 6, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: bf561f9
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor ValidationNotice to use @GtfsValidationNotice(severity) instead of passing SeverityLevel in the constructor

2 participants