Skip to content

fix: Web Validator hangs after supplying non-zip URL #1445#1481

Merged
cka-y merged 2 commits intomasterfrom
issue/1445
Jun 6, 2023
Merged

fix: Web Validator hangs after supplying non-zip URL #1445#1481
cka-y merged 2 commits intomasterfrom
issue/1445

Conversation

@cka-y
Copy link
Copy Markdown
Contributor

@cka-y cka-y commented Jun 5, 2023

Summary:

Fix for bug #1445 : Web Validator hangs after supplying non-zip URL

Expected behavior:
Error is displayed when the supplied url is invalid.

Screenshot 2023-06-05 at 12 04 48 PM

Implementation Details:
The load event for XMLHttpRequest is triggered once the request is complete even in the case of server error status code 500 which we send from web/service/controller/ValidationController.
Ref: https://javascript.info/xmlhttprequest

Please make sure these boxes are checked before submitting your pull request - thanks!

@cka-y cka-y linked an issue Jun 5, 2023 that may be closed by this pull request
@cka-y cka-y merged commit 225dcc6 into master Jun 6, 2023
@cka-y cka-y deleted the issue/1445 branch June 6, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web Validator hangs after supplying non-zip URL

3 participants