You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Specifically, it pulls severityLevel out of Notice and moves it to a new ResolvedNotice class, which is a wrapper around Notice object that includes the resolved severity level. Additionally, the severity level of the notice is resolved when it is added to NoticeContainer, which has been refactored to hold ResolvedNotices now. This paves the way for config-driven severity levels for notices, which could be implemented within NoticeContainer in the future.
✅ Rule acceptance tests passed.
New Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: b3c8475
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.
✅ Rule acceptance tests passed.
New Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: dd64e03
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As originally discussed in https://bit.ly/gtfs-validator-notice-documentation, when we introduced @GtfsValidationNotice to document validation notice, the plan was to follow-up by refactoring SeverityLevel from the notice constructor. This PR performs that refactor.
Specifically, it pulls
severityLevelout ofNoticeand moves it to a newResolvedNoticeclass, which is a wrapper aroundNoticeobject that includes the resolved severity level. Additionally, the severity level of the notice is resolved when it is added toNoticeContainer, which has been refactored to holdResolvedNoticesnow. This paves the way for config-driven severity levels for notices, which could be implemented withinNoticeContainerin the future.Closes #1472.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything