fix(web/service): change permissions for application.properties, service acount json, & newrelic.yml#1453
Merged
davidgamez merged 2 commits intomasterfrom May 29, 2023
Merged
Conversation
…ervice acount json, & newrelic.yml The gcloud-secrets CLI will create these files with 0600 permissions, and does not document an option to change the mode. This patch uses the chown/chmod CLI utilities rather than --chown and --chmod flags because their support is not universal across docker versions or distributions which do not include buildkit (the cloudbuild environment provides one such distribution).
KClough
approved these changes
May 26, 2023
Contributor
Author
|
This change was validated by completing the following build successfully: https://console.cloud.google.com/cloud-build/builds;region=global/9a0cc20f-7604-4c23-a9a4-d76197f17e46?&project=web-based-gtfs-validator |
|
🥳 Congrats on getting your first pull request merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gcloud-secrets CLI will create these files with 0600 permissions, and does not document an option to change the mode. This patch uses the chown/chmod CLI utilities rather than --chown and --chmod flags because their support is not universal across docker versions or distributions which do not include buildkit (the cloudbuild environment provides one such distribution).