You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❌ Invalid acceptance test.
New Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 35 out of 1428 datasets (~2%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1428 sources (~0 %) are corrupted.
Commit: 2228a22
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.
We should consider having a way to ignore specific items in the comparison (e.g. anything related to platform_without_parent_station should be ignored).
Maybe it's already there?
❌ Invalid acceptance test.
New Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 34 out of 1428 datasets (~2%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1428 sources (~0 %) are corrupted.
Commit: a88eb5b
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.
❌ Invalid acceptance test. New Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Warnings: 34 out of 1428 datasets (~2%) are invalid due to code change, which is above the provided threshold of 1%. 0 out of 1428 sources (~0 %) are corrupted. Commit: a88eb5b Download the full acceptance test report here (report will disappear after 90 days). ❌ Invalid acceptance test.
This failure is expected as the PR downgrades a notice from warning to info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Downgraded platform_without_parent_station notice to info.
Relocated the notice to the info section in RULES.md
Expected behavior:
If a stop has no parent station and no platform, it will issue an INFO notice instead of a WARNING.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything