fix: Modified to accept mime type encountered on Windows#1439
Merged
davidgamez merged 2 commits intomasterfrom May 16, 2023
Merged
fix: Modified to accept mime type encountered on Windows#1439davidgamez merged 2 commits intomasterfrom
davidgamez merged 2 commits intomasterfrom
Conversation
|
Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:
|
|
|
jcpitre
force-pushed
the
issue/1404/zip_error_on_windows
branch
from
e3677d2 to
c52b60a
Compare
|
🥳 Congrats on getting your first pull request merged! |
Contributor
|
This is great work @jcpitre! Let's discuss next standup how we can set up testing to catch these kinds of issues in the future. cc @davidgamez (I tested uploading a ZIP file in the interface on a Windows instance when we were reviewing the PRs, but all the GTFS feeds I was using were initially downloaded onto my Mac, which is why this bug wasn't spotted.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1404 On Windows browsers the mime-type of a zip file is application/x-zip-compressed, and we were just allowing mime-type application/zip. Modified to allow the application/x-zip-compressed
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anythingA note about how I tested this PR:
npm run dev -- --host