Skip to content

feat: Include section references in the notice output schema.#1416

Merged
bdferris-v2 merged 1 commit intomasterfrom
issue/1324/notice_schema
May 1, 2023
Merged

feat: Include section references in the notice output schema.#1416
bdferris-v2 merged 1 commit intomasterfrom
issue/1324/notice_schema

Conversation

@bdferris-v2
Copy link
Copy Markdown
Collaborator

@bdferris-v2 bdferris-v2 commented Apr 30, 2023

PR #1366 added section references to @GtfsValidationNotice. This PR updates the notice schema export to include them as well. Continued work on issue #1324

Please make sure these boxes are checked before submitting your pull request - thanks!

@github-actions
Copy link
Copy Markdown
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1426 sources (~0 %) are corrupted.
Commit: 3192170
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdferris-v2 bdferris-v2 merged commit 19ed06d into master May 1, 2023
@bdferris-v2 bdferris-v2 deleted the issue/1324/notice_schema branch May 1, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants