Skip to content

feat: Add unit-test check for @GtfsValidationNotice annotation and notices that I missed#1413

Merged
bdferris-v2 merged 3 commits intomasterfrom
issue/1324/rules_documentation_test
Apr 30, 2023
Merged

feat: Add unit-test check for @GtfsValidationNotice annotation and notices that I missed#1413
bdferris-v2 merged 3 commits intomasterfrom
issue/1324/rules_documentation_test

Conversation

@bdferris-v2
Copy link
Copy Markdown
Collaborator

@bdferris-v2 bdferris-v2 commented Apr 29, 2023

This adds a new NoticeAnnotationTest to make sure each validation notice is annotated with @GtfsValidationNotice. It also adds @GtfsValidationNotices to a number of notices that I missed in the first pass:

  • SystemErrors
  • Files with more than one child Notice class (my script only caught the first notice in the file)

@bdferris-v2 bdferris-v2 requested a review from davidgamez April 29, 2023 03:04
@bdferris-v2 bdferris-v2 linked an issue Apr 29, 2023 that may be closed by this pull request
[feature request / refactor] Produce structured data containing human-readable code descriptions (refactor RULES.md) #1324
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 29, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1426 sources (~0 %) are corrupted.
Commit: ea57209
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

davidgamez
davidgamez approved these changes Apr 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 29, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1426 sources (~0 %) are corrupted.
Commit: 4f9cd5f
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@bdferris-v2 bdferris-v2 merged commit 0dd730a into master Apr 30, 2023
@bdferris-v2 bdferris-v2 deleted the issue/1324/rules_documentation_test branch April 30, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidgamez davidgamez davidgamez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature request / refactor] Produce structured data containing human-readable code descriptions (refactor RULES.md)

2 participants

@bdferris-v2 @davidgamez