Skip to content

chore: ignore web packages on acceptance and e2e tests#1403

Merged
davidgamez merged 1 commit intomasterfrom
chore/ignore-web-e2e-acceptance-tests
Apr 28, 2023
Merged

chore: ignore web packages on acceptance and e2e tests#1403
davidgamez merged 1 commit intomasterfrom
chore/ignore-web-e2e-acceptance-tests

Conversation

@davidgamez
Copy link
Copy Markdown
Member

@davidgamez davidgamez commented Apr 28, 2023 •
edited
Loading

Summary:

The acceptance and E2E tests are time and cost-consuming workflows. As web projects have no impact on the validator's core implementation, we can ignore them in the mentioned test workflows. Web projects run their own independent set of tests.

Expected behavior:

When changes are pushed from web projects, the acceptance and E2E tests should not run.

Please make sure these boxes are checked before submitting your pull request - thanks!

@davidgamez davidgamez marked this pull request as ready for review April 28, 2023 14:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 28, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1426 sources (~0 %) are corrupted.
Commit: 0047f7a
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez requested review from KClough, bdferris-v2 and briandonahue and removed request for themightychris April 28, 2023 14:52
@davidgamez davidgamez merged commit 63bf659 into master Apr 28, 2023
@davidgamez davidgamez deleted the chore/ignore-web-e2e-acceptance-tests branch April 28, 2023 15:00
@bdferris-v2
Copy link
Copy Markdown
Collaborator

bdferris-v2 commented Apr 28, 2023

Won't this change have the same issue as #1339? Namely, acceptance test are required for merging a PR, so if we exclude the workflow, you'll need a repo admin to actually merge the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@themightychris themightychris themightychris approved these changes

@KClough KClough Awaiting requested review from KClough

@bdferris-v2 bdferris-v2 Awaiting requested review from bdferris-v2

+1 more reviewer

@briandonahue briandonahue briandonahue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidgamez @bdferris-v2 @briandonahue @themightychris