feat: Add Sentry Error Monitoring to web validator client + service by KClough · Pull Request #1384 · MobilityData/gtfs-validator

KClough · 2023-04-07T20:11:39Z

Summary:

Resolves #1373

Expected behavior:

Unhandled errors will be captured via Sentry.

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with gradle test to make sure you didn't break anything
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)

* refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <[email protected]>

* Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator.

github-actions · 2023-04-07T21:00:43Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: afef5b3
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

github-actions · 2023-04-08T21:54:12Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: 13ad05d
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

github-actions · 2023-04-08T22:46:05Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: 29cec9e
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

davidgamez · 2023-04-12T20:39:22Z

web/service/src/main/resources/sentry.properties

I think the sentry endpoint should not be set in the repository. We can inject the file or replace its content in the deployment process to be available at runtime.

web/client/src/routes/+page.svelte

github-actions · 2023-04-16T18:06:59Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: 375e53e
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

isabelle-dr · 2023-04-17T14:27:56Z

Is this ready to merge ? 😃

github-actions · 2023-04-18T18:55:46Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: 0d1295a
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

…obilityData#1384) * chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (MobilityData#1369) * Docs: Update notice migration file (MobilityData#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <[email protected]> * feat: Fail acceptance tests on significant change in warnings (MobilityData#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. * Add sentry script to static html header * Add sentry script to web service * Remove sentry properties from source control --------- Co-authored-by: Ryon Coleman <[email protected]> Co-authored-by: Brian Ferris <[email protected]> Co-authored-by: isabelle-dr <[email protected]> Co-authored-by: Emma Blue <[email protected]>

ryon and others added 9 commits April 1, 2023 06:02

chore: fix deprecated dependency

9b983b3

chore: auto-format

b31fef4

feat: handle missing RULES.md

288c543

feat: refactor upload process and handle more errors

ca88baa

Add a more descriptive test failure message to NoticeFieldsTest. (#1369)

7a48fd8

Docs: Update notice migration file (#1357)

352e65b

* refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <[email protected]>

Merge branch 'master' into feat/web-handle-errors

956d5d8

Add sentry script to static html header

7fae319

Add sentry script to web service

3a8018e

Merge branch 'master' into feat/web-client-sentry

e37efd2

KClough marked this pull request as ready for review April 8, 2023 21:55

davidgamez reviewed Apr 12, 2023

View reviewed changes

KClough added 2 commits April 16, 2023 13:14

Merge branch 'master' into feat/web-client-sentry

e3af5ed

Remove sentry properties from source control

d3a4e6d

KClough requested a review from davidgamez April 16, 2023 20:16

davidgamez approved these changes Apr 17, 2023

View reviewed changes

Merge branch 'master' into feat/web-client-sentry

6daee39

KClough merged commit bc96524 into master Apr 18, 2023

KClough deleted the feat/web-client-sentry branch April 18, 2023 18:56

briandonahue mentioned this pull request Apr 20, 2023

Build error: Task :web:service:compileJava FAILED - can't find Sentry #1394

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add Sentry Error Monitoring to web validator client + service#1384

feat: Add Sentry Error Monitoring to web validator client + service#1384
KClough merged 14 commits intomasterfrom
feat/web-client-sentry

KClough commented Apr 7, 2023

Uh oh!

github-actions bot commented Apr 7, 2023

Uh oh!

github-actions bot commented Apr 8, 2023

Uh oh!

github-actions bot commented Apr 8, 2023

Uh oh!

davidgamez Apr 12, 2023

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

isabelle-dr commented Apr 17, 2023

Uh oh!

github-actions bot commented Apr 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

KClough commented Apr 7, 2023

Uh oh!

github-actions bot commented Apr 7, 2023

Uh oh!

github-actions bot commented Apr 8, 2023

Uh oh!

github-actions bot commented Apr 8, 2023

Uh oh!

davidgamez Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

isabelle-dr commented Apr 17, 2023

Uh oh!

github-actions bot commented Apr 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants