chore: Add unit tests to AnyTableLoader by davidgamez · Pull Request #1380 · MobilityData/gtfs-validator

davidgamez · 2023-04-06T12:02:32Z

Summary:

Add unit tests to AnyTableLoader preparing the class for future refactoring.

Expected behavior:

Unit tests cover error scenarios and a happy path.

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with gradle test to make sure you didn't break anything
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)

github-actions · 2023-04-06T12:53:49Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1424 sources (~0 %) are corrupted.
Commit: 216d604
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

github-actions · 2023-04-06T14:43:58Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1424 sources (~0 %) are corrupted.
Commit: b3d28b5
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java

core/src/test/java/org/mobilitydata/gtfsvalidator/TestUtils.java

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java

core/src/test/java/org/mobilitydata/gtfsvalidator/testgtfs/GtfsStop.java

github-actions · 2023-04-10T13:53:23Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: dca8886
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

github-actions · 2023-04-11T18:08:32Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: eea501f
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

core/src/test/java/org/mobilitydata/gtfsvalidator/TestUtils.java

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java

core/src/test/java/org/mobilitydata/gtfsvalidator/validator/ValidatorLoaderTest.java

github-actions · 2023-04-13T16:13:09Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: 3ea5f26
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

github-actions · 2023-04-17T16:55:34Z

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

…lity verification

…ws test

Remove DefaultTableHeaderValidator and DefaultValidatorProvider test dependencies

github-actions · 2023-04-18T15:32:33Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: bc205bd
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

github-actions · 2023-04-18T16:40:50Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: c1a6df1
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

github-actions · 2023-04-18T20:27:51Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: d40a1e9
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

davidgamez marked this pull request as ready for review April 6, 2023 14:16

davidgamez requested a review from bdferris-v2 April 6, 2023 16:54

bdferris-v2 reviewed Apr 6, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java Outdated Show resolved Hide resolved

bdferris-v2 reviewed Apr 6, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java Outdated Show resolved Hide resolved

bdferris-v2 reviewed Apr 6, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java Outdated Show resolved Hide resolved

bdferris-v2 reviewed Apr 6, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/TestUtils.java Outdated Show resolved Hide resolved

bdferris-v2 reviewed Apr 6, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java Outdated Show resolved Hide resolved

bdferris-v2 reviewed Apr 6, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java Outdated Show resolved Hide resolved

bdferris-v2 reviewed Apr 6, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java Outdated Show resolved Hide resolved

bdferris-v2 reviewed Apr 6, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java Outdated Show resolved Hide resolved

bdferris-v2 reviewed Apr 6, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoaderTest.java Outdated Show resolved Hide resolved

bdferris-v2 reviewed Apr 6, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/testgtfs/GtfsStop.java Outdated Show resolved Hide resolved

davidgamez force-pushed the chore/table-loader-unit-tests branch from 6422dcd to 71ef45e Compare April 10, 2023 12:59

davidgamez requested a review from bdferris-v2 April 11, 2023 18:12

bdferris-v2 reviewed Apr 13, 2023

View reviewed changes

core/src/test/java/org/mobilitydata/gtfsvalidator/TestUtils.java Show resolved Hide resolved