feat: Add a more descriptive test failure message to NoticeFieldsTest. by bdferris-v2 · Pull Request #1369 · MobilityData/gtfs-validator

bdferris-v2 · 2023-03-31T18:54:50Z

Summary:

To make it easier to understand what this test failure means, I've added a more descriptive failure message. The failure now looks like:

Run the unit tests with gradle test to make sure you didn't break anything
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)

github-actions · 2023-03-31T20:16:41Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1423 sources (~0 %) are corrupted.
Commit: b483921
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

github-actions · 2023-04-04T15:50:57Z

✅ Rule acceptance tests passed.
New Errors: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1424 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1424 sources (~0 %) are corrupted.
Commit: 3662854
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

…ilityData#1369)

* chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (#1369) * Docs: Update notice migration file (#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <[email protected]> * feat: Fail acceptance tests on significant change in warnings (#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. --------- Co-authored-by: Ryon Coleman <[email protected]> Co-authored-by: Brian Ferris <[email protected]> Co-authored-by: isabelle-dr <[email protected]> Co-authored-by: Emma Blue <[email protected]> Co-authored-by: David Gamez <[email protected]>

…1384) * chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (#1369) * Docs: Update notice migration file (#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <[email protected]> * feat: Fail acceptance tests on significant change in warnings (#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. * Add sentry script to static html header * Add sentry script to web service * Remove sentry properties from source control --------- Co-authored-by: Ryon Coleman <[email protected]> Co-authored-by: Brian Ferris <[email protected]> Co-authored-by: isabelle-dr <[email protected]> Co-authored-by: Emma Blue <[email protected]>

…ilityData#1369)

* chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (MobilityData#1369) * Docs: Update notice migration file (MobilityData#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <[email protected]> * feat: Fail acceptance tests on significant change in warnings (MobilityData#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. --------- Co-authored-by: Ryon Coleman <[email protected]> Co-authored-by: Brian Ferris <[email protected]> Co-authored-by: isabelle-dr <[email protected]> Co-authored-by: Emma Blue <[email protected]> Co-authored-by: David Gamez <[email protected]>

…obilityData#1384) * chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (MobilityData#1369) * Docs: Update notice migration file (MobilityData#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <[email protected]> * feat: Fail acceptance tests on significant change in warnings (MobilityData#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. * Add sentry script to static html header * Add sentry script to web service * Remove sentry properties from source control --------- Co-authored-by: Ryon Coleman <[email protected]> Co-authored-by: Brian Ferris <[email protected]> Co-authored-by: isabelle-dr <[email protected]> Co-authored-by: Emma Blue <[email protected]>

* chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (#1369) * Docs: Update notice migration file (#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <[email protected]> * feat: Fail acceptance tests on significant change in warnings (#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. * Add sentry script to static html header * Add sentry script to web service * Remove sentry properties from source control * feat: add newrelic agent to web service --------- Co-authored-by: Ryon Coleman <[email protected]> Co-authored-by: Brian Ferris <[email protected]> Co-authored-by: isabelle-dr <[email protected]> Co-authored-by: Emma Blue <[email protected]>

Add a more descriptive test failure message to NoticeFieldsTest.

5ca1795

bdferris-v2 requested a review from davidgamez March 31, 2023 18:54

davidgamez approved these changes Apr 4, 2023

View reviewed changes

Merge branch 'master' into issue/1324/rules_documentation_test

dadf8f2

bdferris-v2 merged commit ead50b2 into master Apr 4, 2023

bdferris-v2 deleted the issue/1324/rules_documentation_test branch April 4, 2023 17:15

KClough pushed a commit to JarvusInnovations/gtfs-validator that referenced this pull request Apr 7, 2023

Add a more descriptive test failure message to NoticeFieldsTest. (Mob…

7a48fd8

…ilityData#1369)

bradyhunsaker pushed a commit to bradyhunsaker/gtfs-validator that referenced this pull request Apr 25, 2023

Add a more descriptive test failure message to NoticeFieldsTest. (Mob…

3a782b1

…ilityData#1369)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add a more descriptive test failure message to NoticeFieldsTest.#1369

feat: Add a more descriptive test failure message to NoticeFieldsTest.#1369
bdferris-v2 merged 2 commits intomasterfrom
issue/1324/rules_documentation_test

bdferris-v2 commented Mar 31, 2023

Uh oh!

github-actions bot commented Mar 31, 2023

Uh oh!

github-actions bot commented Apr 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bdferris-v2 commented Mar 31, 2023

Uh oh!

github-actions bot commented Mar 31, 2023

Uh oh!

github-actions bot commented Apr 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants