Skip to content

feat: Move key annotation and entity interfaces into a new model module#1362

Merged
bdferris-v2 merged 2 commits intomasterfrom
issue/1324/model_refactor
Mar 25, 2023
Merged

feat: Move key annotation and entity interfaces into a new model module#1362
bdferris-v2 merged 2 commits intomasterfrom
issue/1324/model_refactor

Conversation

@bdferris-v2
Copy link
Copy Markdown
Collaborator

This will allow us to break up some potential circular dependencies with upcoming support for notice documentation generation, as discussed in #1324 and #1361.

Please make sure these boxes are checked before submitting your pull request - thanks!

…This will allow us to break up some potential circular dependencies with upcoming support for notice documentation generation.
@github-actions
Copy link
Copy Markdown
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1423 sources (~0 %) are corrupted.
Commit: 4a1d7a5
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@bdferris-v2
Copy link
Copy Markdown
Collaborator Author

Now wondering if this should have been core/model instead. I could see an argument for splitting up core into other submodules, such as core/io or core/notices.

@davidgamez
Copy link
Copy Markdown
Member

davidgamez commented Mar 24, 2023

Now wondering if this should have been core/model instead. I could see an argument for splitting up core into other submodules, such as core/io or core/notices.

We can always start with this simple approach(just model) and refactor in the future adding the model back to the core as core/model and the other core children.

@bdferris-v2
Copy link
Copy Markdown
Collaborator Author

Fair enough.

Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Copy Markdown
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1423 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1423 sources (~0 %) are corrupted.
Commit: 0602954
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@bdferris-v2 bdferris-v2 merged commit 2069c96 into master Mar 25, 2023
@bdferris-v2 bdferris-v2 deleted the issue/1324/model_refactor branch March 25, 2023 00:22
ryon pushed a commit to JarvusInnovations/gtfs-validator that referenced this pull request Apr 1, 2023
…This will allow us to break up some potential circular dependencies with upcoming support for notice documentation generation. (MobilityData#1362)
bradyhunsaker pushed a commit to bradyhunsaker/gtfs-validator that referenced this pull request Apr 25, 2023
…This will allow us to break up some potential circular dependencies with upcoming support for notice documentation generation. (MobilityData#1362)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request / refactor] Produce structured data containing human-readable code descriptions (refactor RULES.md)

2 participants