fix: generate errors when missing lat/long for stops, stations, entrances by briandonahue · Pull Request #1321 · MobilityData/gtfs-validator

briandonahue · 2023-02-01T22:34:10Z

Summary:

Generate error notice when Latitude and/or Longitude is not supplied for stops (location_type=0), stations (location_type=1) or entrances/exits (location_type=2).

Addresses #1180

Expected behavior:

Should throw an error when missing geocoordinate data for stops, stations, entrances/exits

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with gradle test to make sure you didn't break anything
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s) (N/A)

…nces

main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopLatLongValidator.java

main/src/test/java/org/mobilitydata/gtfsvalidator/validator/StopLatLongValidatorTest.java

briandonahue · 2023-02-08T19:42:59Z

@bdferris-v2 I believe all your suggestions are now implemented, thanks for reviewing!

bdferris-v2

LGTM

bdferris-v2 · 2023-02-08T20:40:42Z

@briandonahue one other issue: I think the code formatting check is failing on your PR. Can you run the Gradle goJF command on your code to format it properly and update the PR? Thanks!

isabelle-dr · 2023-02-10T15:58:36Z

@briandonahue and @bdferris-v2 sorry to arrive late on this PR, the documentation is missing for this new notice.
I know we are discussing generating RULES.md automatically, but in the meantime, we need it 😊.
The HTML report links directly to RULES.md to tell users what the notice is, and how to fix it.

Also, I acknowledge that a review by a core developer is enough to unblock the merge (thank you @bdferris-v2), but please wait for a MobilityData staff to review as well before merging. I know our capacity doesn't allow us to review right away, but we need to acknowledge what has been merged on this project so that we can:

close the issue if needed, open follow-up issues
coordinate with other contributors (for example, PR Add a list of validators that meet the official GTFS requirements #1315 contains the same fix)
make sure dependencies (like the docs) have been updated
answer questions
Many thanks 🙏

…nces (MobilityData#1321) * Add validation and test for missing lat/lon on Stops, Stations, Entrances * Rename validator for clarity and differentiation of generated validator * inline builder for readability * rename notice class for consistency * use static import * Remove unnecessary comment * formatting

Add validation and test for missing lat/lon on Stops, Stations, Entra…

7f100ec

…nces

briandonahue changed the title ~~Add validation and test for missing lat/lon on Stops, Stations, Entra…~~ fix: generate errors when missing lat/long for stops, stations, entrances Feb 1, 2023

bdferris-v2 reviewed Feb 6, 2023

View reviewed changes

main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopLatLongValidator.java Outdated Show resolved Hide resolved