fix 878: require agency_id when more than one agency, warn when only one#1318
Merged
fredericsimard merged 11 commits intoMobilityData:masterfrom Mar 6, 2023
Merged
Conversation
Contributor
|
See my latest comment here in case that helps :) |
4 tasks
Contributor
Author
|
@isabelle-dr I think this is ready for review. I've also commented on #1315 where I think there may be some redundancy with the |
bdferris-v2
reviewed
Feb 9, 2023
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/AgencyConsistencyValidator.java
Show resolved
Hide resolved
bdferris-v2
reviewed
Feb 9, 2023
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/RouteAgencyIdValidator.java
Show resolved
Hide resolved
bdferris-v2
reviewed
Feb 9, 2023
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/RouteAgencyIdValidatorTest.java
Outdated
Show resolved
Hide resolved
bdferris-v2
reviewed
Feb 9, 2023
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/RouteAgencyIdValidatorTest.java
Show resolved
Hide resolved
Contributor
|
Sounds good, I will have a look shortly :) |
briandonahue
changed the title
4 tasks
bdferris-v2
approved these changes
Mar 6, 2023
isabelle-dr
approved these changes
Mar 6, 2023
Contributor
isabelle-dr
left a comment
isabelle-dr
left a comment
There was a problem hiding this comment.
LGTM, thank you @briandonahue for working on this!
ryon
pushed a commit
to JarvusInnovations/gtfs-validator
that referenced
this pull request
Apr 1, 2023
…one (MobilityData#1318) * fix: require agency_id when more than one agency, warn when only one * Remove custom error, use MissingRecommendedField * Add agency_id validation for fare_attributes.txt, make consistent with routes.txt validator * formatting * Update references for missing_recommended_field warning * Account for possibility of 0 agencies * add no notice test cases for routes.txt * inline method * add no notice test cases for fare_attributes.txt --------- Co-authored-by: Kevin Clough <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #878
agency_idif more than one agency inagency.txtagency.txtbutagency_idis not providedagency_idis missing inroutes.txtand a single agency is defined inagency.txtwith noagency_idagency_idis missing inroutes.txtbut is included for single agency inagency.txtExpected behavior:
N/A
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything