Add a list of validators that meet the official GTFS requirements by aababilov · Pull Request #1315 · MobilityData/gtfs-validator

aababilov · 2023-01-19T02:55:58Z

BlockTripsWithConsistentTypeValidator
- Validates that trips that belong to the same block have consistent route types (e.g., bus does not transfer to rail).
- Generated notice: BlockTripsWithInconsistentRouteTypesNotice.
FareAttributeAgencyIdValidator
- Checks that fare_attributes.agency_id field is defined for every row if there is more than 1 agency in the feed.
- Generated notice: MissingRequiredFieldNotice.
FeedHasLanguageValidator
- Checks that a feed has language defined in either feed_info.feed_lang or agency.agency_lang. Note that feed_lang is a required field: if there is a feed_info entity, it must have feed_lang set. agency_lang, instead, is optional. The recommended way is to provide feed_lang and omit agency_lang.
- Generated notice: FeedHasNoLanguageNotice.
StationUsageValidator
- Checks that every station (location_type=1) in stops.txt has child platforms ( location_type=0). Note that a station that has child entrances (location_type=2) or generic nodes (location_type=3) is also reported.
- Generated notice: StationWithoutPlatformsNotice.
StopLatLngRequiredValidator
- Checks that conditionally required fields stop_lat and stop_lon are set depending on location_type.
  - stop_lat and stop_lon are required for stations (location_type=0), stops (location_type=1) and entrances (location_type=2) and optional for other types.
- Generated notice: MissingRequiredFieldError.
StopTimeInSequenceOrderValidator
- Validates that fields arrival_time, departure_time and shape_dist_traveled are non-decreasing along each trip.
- Generated notices:
  - TripWithOutOfOrderArrivalTimeNotice
  - TripWithOutOfOrderDepartureTimeNotice
  - TripWithOutOfOrderShapeDistTraveledNotice
TransferFrequencyBasedTripValidator
- Validates that trip-to-trip transfers do not involve frequency-based trips.
- Generated notice: TransferForFrequencyBasedTripNotice.
TripShapeDistTraveledValidator
- Validates that trips specify stop_times.shape_dist_traveled values properly. Please see generated notices for details.
- Generated notices:
  - TripWithShapeDistTraveledButNoShapeNotice
  - TripWithShapeDistTraveledButNoShapeDistancesNotice
  - TripWithPartialShapeDistTraveledNotice

* BlockTripsWithConsistentTypeValidator * FareAttributeAgencyIdValidator * FeedHasLanguageValidator * StationUsageValidator * StopNameLatLngRequiredValidator * StopTimeInSequenceOrderValidator * TransferFrequencyBasedTripValidator * TripShapeDistTraveledValidator

asvechnikov2

Thanks! LGTM.

Hi @isabelle-dr, could you please take a look at the proposed validations if they look good? Do you know if there are any open issues that could be closed by this change?

...ain/java/org/mobilitydata/gtfsvalidator/validator/BlockTripsWithConsistentTypeValidator.java

main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FeedHasLanguageValidator.java

main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StationUsageValidator.java

.../src/main/java/org/mobilitydata/gtfsvalidator/validator/StopNameLatLngRequiredValidator.java

...src/main/java/org/mobilitydata/gtfsvalidator/validator/StopTimeInSequenceOrderValidator.java

.../main/java/org/mobilitydata/gtfsvalidator/validator/TransferFrequencyBasedTripValidator.java

main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripShapeDistTraveledValidator.java

It partially overlaps with StopTimeIncreasingDistanceValidator, so we will move it to a separate pull request.

isabelle-dr · 2023-01-25T14:51:17Z

Thanks for the ping @asvechnikov2! (and.. wow @aababilov 🎉).
I will have a look this week, looking forward to it 😊

bdferris-v2 · 2023-01-25T22:52:44Z

The LGTM. However, you do need to update RULES.md with the new validation notices you've added.

bdferris-v2 · 2023-01-25T22:53:40Z

I'd also call out that issue #1304 is probably still blocking us from getting a clean acceptance test run.

briandonahue · 2023-02-08T19:56:05Z

main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FareAttributeAgencyIdValidator.java

+  public void validate(NoticeContainer noticeContainer) {
+    if (agencyTable.entityCount() <= 1) {
+      // fare_attributes.agency_id is not required when there is a single agency.
+      return;


@isabelle-dr @aababilov I've added similar logic as part of #1318 and added a best practice MissingRecommendedFieldNotice warning to recommend that agency_id be included even when there is only one agency.

isabelle-dr · 2023-02-09T22:28:23Z

Hello! Sorry it took a while. A few things here:

FeedHasLanguageValidator
Is this mentioned in the spec somewhere? I couldn't find it. Adding this to the spec looks like a breaking change. Maybe something to add in the best Practice and flag as a warning here? Where is this coming from?
StationUsageValidator
Reading the spec, I think stations without any children are okay? Please tell me if you think otherwise.
BlockTripsWithConsistentTypeValidator, TransferFrequencyBasedTripValidator and TripShapeDistTraveledValidator
These new validators make a lot of sense! That being said, so explicit spec mention. I suggest we first amend the spec and then merge them. Happy to propose the changes.
StopLatLngRequiredValidator-> it looks like it has been solved in fix: generate errors when missing lat/long for stops, stations, entrances #1321 by @briandonahue
FareAttributeAgencyIdValidator -> LGTM
StopTimeInSequenceOrderValidator -> it looks like it's also in Validate that arrival_time, departure_time and shape_dist_traveled are non-decreasing along each trip #1319

isabelle-dr · 2023-02-09T22:33:30Z

I suggest we split this PR between what's explicitly mentioned in spec VS what is not.
What is explicitly mentioned: we just need the documentation update and we're good to merge.
What isn't: add the clear statements in the spec itself, and then merge

aababilov requested a review from asvechnikov2 January 19, 2023 02:56

aababilov force-pushed the many-validators branch 2 times, most recently from ec85aba to a35c231 Compare January 19, 2023 02:58

aababilov force-pushed the many-validators branch from a35c231 to f85c737 Compare January 19, 2023 03:12

asvechnikov2 approved these changes Jan 25, 2023

View reviewed changes

asvechnikov2 requested a review from isabelle-dr January 25, 2023 03:30

aababilov added 2 commits January 25, 2023 14:54

Update comments and remove validation of the required stop_name

7da9c4e

Remove StopTimeInSequenceOrderValidator

37228f9

It partially overlaps with StopTimeIncreasingDistanceValidator, so we will move it to a separate pull request.

briandonahue reviewed Feb 8, 2023

View reviewed changes

briandonahue mentioned this pull request Feb 8, 2023

fix 878: require agency_id when more than one agency, warn when only one #1318

Merged

4 tasks

isabelle-dr mentioned this pull request Feb 9, 2023

Add a rule that checks the presence of stop_lat & stop_lon in stops.txt #1180

Closed

Merge branch 'master' into many-validators

efcc7d2

isabelle-dr linked an issue Feb 10, 2023 that may be closed by this pull request

Add a rule that checks the presence of stop_lat & stop_lon in stops.txt #1180

Closed

isabelle-dr mentioned this pull request Feb 10, 2023

fix: generate errors when missing lat/long for stops, stations, entrances #1321

Merged

4 tasks

aababilov closed this Feb 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a list of validators that meet the official GTFS requirements#1315

Add a list of validators that meet the official GTFS requirements#1315
aababilov wants to merge 4 commits intoMobilityData:masterfrom
aababilov:many-validators

aababilov commented Jan 19, 2023 •

edited by asvechnikov2

Loading

Uh oh!

asvechnikov2 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isabelle-dr commented Jan 25, 2023

Uh oh!

bdferris-v2 commented Jan 25, 2023

Uh oh!

bdferris-v2 commented Jan 25, 2023

Uh oh!

briandonahue Feb 8, 2023

Uh oh!

isabelle-dr commented Feb 9, 2023 •

edited

Loading

Uh oh!

isabelle-dr commented Feb 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

aababilov commented Jan 19, 2023 • edited by asvechnikov2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asvechnikov2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isabelle-dr commented Jan 25, 2023

Uh oh!

bdferris-v2 commented Jan 25, 2023

Uh oh!

bdferris-v2 commented Jan 25, 2023

Uh oh!

briandonahue Feb 8, 2023

Choose a reason for hiding this comment

Uh oh!

isabelle-dr commented Feb 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isabelle-dr commented Feb 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aababilov commented Jan 19, 2023 •

edited by asvechnikov2

Loading

isabelle-dr commented Feb 9, 2023 •

edited

Loading