feat: apply recommended file notice to feed_info#1197
Merged
maximearmstrong merged 5 commits intoMobilityData:masterfrom Jun 29, 2022
Merged
Conversation
maximearmstrong
approved these changes
Jun 28, 2022
26edb98 to
03eb4d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves #877
Adds a new annotation for recommended files and applies this annotation to
feed_info.txtand.shapes.txtExpected behavior:
A new validator warning is generated when either
feed_info.txtis missingPlease make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anythingHere is the sample output from the validator for a data set with missing
feed_info.txt:{ "notices": [ { "code": "missing_recommended_file", "severity": "WARNING", "totalNotices": 1, "sampleNotices": [ { "filename": "feed_info.txt" } ] } ]}