fix: Bug with ssl network connections + Java module permissions.#1182
Merged
maximearmstrong merged 1 commit intoMobilityData:masterfrom Jun 7, 2022
Merged
fix: Bug with ssl network connections + Java module permissions.#1182maximearmstrong merged 1 commit intoMobilityData:masterfrom
maximearmstrong merged 1 commit intoMobilityData:masterfrom
Conversation
Collaborator
Author
|
Heads up to @maximearmstrong and @isabelle-dr |
bdferris-v2
changed the title
maximearmstrong
approved these changes
Jun 7, 2022
Contributor
|
Thank you @bdferris-v2! |
maximearmstrong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #1181. Basically, the packaged app uses Java Modules, which requires explicit listing of all JRE dependencies.
jdepspicks up most of them, but we have a hidden dependency on the JRE's crypto functionality in order to pull https:// urls. This manifested as an exception when querying the current app version from https://raw.githubusercontent.com but it also repros if you attempt to download an https:// feed.Closes #1181.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything