Skip to content

feat: Add an icon for the GUI application#1179

Merged
isabelle-dr merged 20 commits intoMobilityData:masterfrom
bdferris-v2:issue/1162/icons
Jun 3, 2022
Merged

feat: Add an icon for the GUI application#1179
isabelle-dr merged 20 commits intoMobilityData:masterfrom
bdferris-v2:issue/1162/icons

Conversation

@bdferris-v2
Copy link
Copy Markdown
Collaborator

Summary:

Replaces the default Java icon used for the packaged application.

Screen Shot 2022-06-03 at 9 11 07 AM

Closes #1162

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bdferris-v2
❌ bdferris
You have signed the CLA already but the status is still pending? Let us recheck it.

@bdferris-v2 bdferris-v2 requested a review from isabelle-dr June 3, 2022 18:10
@bdferris-v2
Copy link
Copy Markdown
Collaborator Author

Note that I accidentally had one commit in this PR that used my [email protected] address (as opposed to [email protected]), so CLA Assistant is going to complain. Sorry I missed that!

@isabelle-dr
Copy link
Copy Markdown
Contributor

Thank you so much @bdferris! LGTM. If you're not planning other additions, I can merge & publish the release (🎉)

@bdferris-v2
Copy link
Copy Markdown
Collaborator Author

I've got one more tweak for the in-app icon. Give me five minutes, almost there.

@isabelle-dr
Copy link
Copy Markdown
Contributor

I'm surprised the Package Application didn't run, I thought it would be triggered on every commit?

@bdferris-v2
Copy link
Copy Markdown
Collaborator Author

@isabelle-dr
Copy link
Copy Markdown
Contributor

Oh okay, it is Package Installers. It looks great!

@bdferris-v2
Copy link
Copy Markdown
Collaborator Author

@isabelle-dr the CLA Assistant is still blocking this, such that I don't think I can submit on my own. Do you have the power to override?

@isabelle-dr
Copy link
Copy Markdown
Contributor

I do :)
Are you done on your end?

@bdferris
Copy link
Copy Markdown
Contributor

bdferris commented Jun 3, 2022 via email

@isabelle-dr isabelle-dr merged commit da57dbf into MobilityData:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an icon for the GUI application

4 participants