feat: Check for new version of app during validation#1176
feat: Check for new version of app during validation#1176isabelle-dr merged 8 commits intoMobilityData:masterfrom
Conversation
…ion is available.
main/src/main/java/org/mobilitydata/gtfsvalidator/util/VersionResolver.java
Show resolved
Hide resolved
maximearmstrong
left a comment
maximearmstrong
left a comment
There was a problem hiding this comment.
Thanks @bdferris-v2, this is great. I left some questions and suggestions in-line.
Also, did you create the wiki page manually @bdferris-v2 ? I'm mainly asking to know if we will have to update the version manually or is that part of the process?
app/gui/src/main/java/org/mobilitydata/gtfsvalidator/app/gui/GtfsValidatorApp.java
Outdated
Show resolved
Hide resolved
app/gui/src/main/java/org/mobilitydata/gtfsvalidator/app/gui/ValidationDisplay.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/report/HtmlReportGenerator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/ReportSummary.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/report/HtmlReportGenerator.java
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/util/VersionResolver.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/util/VersionResolver.java
Outdated
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/util/VersionInfoTest.java
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/util/VersionResolverTest.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java
Outdated
Show resolved
Hide resolved
|
@maximearmstrong to answer your original question, I just created the wiki page manually. I believe we would also update it manually as needed. It would probably get its own step in the Release instructions. |
|
Just to bump this: any remaining concerns? |
|
It looks like all the comments from @maximearmstrong and @barbeau were addressed. Since he is off today, I will go ahead and merge this PR. This way, it can be included in the release :). Thank you @bdferris for this great addition to the app! |
4 participants
Summary:
Adds functionality to to compare the current app version against the latest release version (per this wiki page).
Closes #1171
Expected behavior:
When a new version of the app is available, show notices in the validation report and the gui application.
gradle testto make sure you didn't break anything