fix: Docker Image push to GitHub Container Registry#1142
Merged
maximearmstrong merged 2 commits intomasterfrom May 11, 2022
Merged
fix: Docker Image push to GitHub Container Registry#1142maximearmstrong merged 2 commits intomasterfrom
maximearmstrong merged 2 commits intomasterfrom
Conversation
…ow [acceptance test skip]
barbeau
approved these changes
May 11, 2022
Member
barbeau
left a comment
barbeau
left a comment
There was a problem hiding this comment.
Thanks @maximearmstrong! We can confirm this works after merge to main branch.
Contributor
|
Thank you for this contribution! 🍰✨🦄 Information about source corruption0 out of 1248 sources are corrupted. Acceptance test detailsThe changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase. |
Contributor
Author
It worked! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1105 : Docker builds are failing
This PR replaces the Personal Access Token (PAT) used in the
docker.ymlworkflow with a GitHub Token. According to GitHub, PATs used to authenticate toghcr.ioshould be avoided.Along with the changes made in this PR, the steps shown here were followed so that the package could access the GitHub token.
Expected behavior:
The Docker Image push to GitHub Container Registry should work properly.
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anythingInclude screenshot(s) showing how this pull request works and fixes the issue(s)