ci: Remove ubuntu-20.04 from CI#1141
Merged
maximearmstrong merged 2 commits intomasterfrom May 11, 2022
Merged
Conversation
I believe ubuntu-20.04 was originally added to troubleshoot issues discussed in PR #1086, which have since been resolved. Given that: * we have a lot of CI tests running, which makes review of the CI tests challenging (see #1095) * these seem to be redundant given that we're also running on `ubuntu-latest` ...I'm proposing that we remove running on this specific version of ubuntu. This should remove 6 redundant checks (3 occurrences x 2 for each Java version 11 and 17).
|
|
Contributor
|
Thank you for this contribution! 🍰✨🦄 Information about source corruption0 out of 1248 sources are corrupted. Acceptance test detailsThe changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase. |
Contributor
|
Thank you for this contribution! 🍰✨🦄 Information about source corruption0 out of 1248 sources are corrupted. Acceptance test detailsThe changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase. |
maximearmstrong
approved these changes
May 11, 2022
Contributor
maximearmstrong
left a comment
maximearmstrong
left a comment
There was a problem hiding this comment.
I agree with you @barbeau. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I believe ubuntu-20.04 was originally added to troubleshoot issues discussed in PR #1086, which have since been resolved.
Given that:
ubuntu-latest...I'm proposing that we remove running on this specific version of ubuntu.
This should remove 6 redundant checks (3 occurrences x 2 for each Java version 11 and 17) and will also reduce the amount of time required for all CI checks to complete.
Expected behavior:
Don't run redundant CI tests.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything