Skip to content

fix: SystemStubs test dependency#1140

Merged
maximearmstrong merged 1 commit intomasterfrom
test-dependendy-system-stubs
May 11, 2022
Merged

fix: SystemStubs test dependency#1140
maximearmstrong merged 1 commit intomasterfrom
test-dependendy-system-stubs

Conversation

@maximearmstrong
Copy link
Copy Markdown
Contributor

Summary:

This PR:

  • removes System Lambda from build.gradle
  • updates the implementation of SystemStubs to be a testImplementation
  • updates the version of SystemStubs

Expected behavior:

Same as before, but the dependency to SystemStubs won't be packaged in the JAR file.

Please make sure these boxes are checked before submitting your pull request - thanks!

@maximearmstrong maximearmstrong requested a review from barbeau May 11, 2022 19:42
@maximearmstrong maximearmstrong self-assigned this May 11, 2022
@maximearmstrong maximearmstrong marked this pull request as ready for review May 11, 2022 19:43
Copy link
Copy Markdown
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barbeau
Copy link
Copy Markdown
Member

barbeau commented May 11, 2022

Hmmm...some checks are failing - maybe try re-running them?

@maximearmstrong
Copy link
Copy Markdown
Contributor Author

Hmmm...some checks are failing - maybe try re-running them?

Yes, for some reason the checks sometimes fail to find com.github.sherter.google-java-format, but succeed when re-run.

@maximearmstrong maximearmstrong merged commit a5a68f5 into master May 11, 2022
@maximearmstrong maximearmstrong deleted the test-dependendy-system-stubs branch May 11, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants