Skip to content

Docs: fix typo for Missing RequiredFileNotice#1130

Merged
maximearmstrong merged 1 commit intomasterfrom
isabelle-dr-patch-NOTICES.md
May 3, 2022
Merged

Docs: fix typo for Missing RequiredFileNotice#1130
maximearmstrong merged 1 commit intomasterfrom
isabelle-dr-patch-NOTICES.md

Conversation

@isabelle-dr
Copy link
Copy Markdown
Contributor

Summary:
The table in NOTICES.md was showing more values than what the notice produced.

Expected behaviour:
Only the file name is produced by this notice, as seen in the MissingRequiredFileNotice.java file:

public class MissingRequiredFileNotice extends ValidationNotice {
  private final String filename;

  public MissingRequiredFileNotice(String filename) {
    super(SeverityLevel.ERROR);
    this.filename = filename;
  }
}

Please make sure these boxes are checked before submitting your pull request - thanks!

- [ ] Run the unit tests with gradle test to make sure you didn't break anything

@isabelle-dr isabelle-dr added the documentation Anything related to our documentation label Apr 29, 2022
Copy link
Copy Markdown
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @isabelle-dr

@maximearmstrong maximearmstrong merged commit 25c909d into master May 3, 2022
@maximearmstrong maximearmstrong deleted the isabelle-dr-patch-NOTICES.md branch May 3, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Anything related to our documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants