fix: Set encoding to UTF-8 for Javadoc generation#1121
Merged
maximearmstrong merged 1 commit intomasterfrom Apr 20, 2022
Merged
fix: Set encoding to UTF-8 for Javadoc generation#1121maximearmstrong merged 1 commit intomasterfrom
maximearmstrong merged 1 commit intomasterfrom
Conversation
4 tasks
Contributor
|
Thank you for this contribution! 🍰✨🦄 Information about source corruption0 out of 1248 sources are corrupted. Acceptance test detailsThe changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase. |
maximearmstrong
approved these changes
Apr 20, 2022
Contributor
maximearmstrong
left a comment
maximearmstrong
left a comment
There was a problem hiding this comment.
Thanks @barbeau !
maximearmstrong
pushed a commit
that referenced
this pull request
Apr 20, 2022
…ow (#1093) * try multiple versions of java in CI * additional information regarding the version used * same thing with pack and doc jobs * additional OS * additional OS only on test job * remove duplicate job prep * run on multiple OS on pack and doc jobs * additional OS on package job * persist artifacts for all OS used * compileTestJava * use code instead of emoji * do not use compileTestJava * Revert "use code instead of emoji" This reverts commit 9a068e8. * do not run doc job on window-latest for now * fix syntax * rename task and specify prepare-version-name in needs * add instructions for encoding while generating the javadocs * run doc job on windows-latest * chore: Remove extra Javadoc config This was fixed in #1121 Co-authored-by: Sean Barbeau <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As mentioned in #1101 (comment), we need to configure character encoding for the Javadoc generation plugin separately.
This PR sets the character encoding for the Javadoc plugin.
This PR should also unblock PR #1093.
Closes #1101
Expected behavior:
./gradlew aggregateJavadocssuccessfully runs on Windows.I've tested on Windows 10 Home using JDK 11.0.12
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything