ci: Change Java distribution adopt->temurin#1118
Merged
isabelle-dr merged 1 commit intomasterfrom Apr 12, 2022
Merged
Conversation
https://github.com/actions/setup-java#supported-distributions says: >NOTE: Adopt OpenJDK got moved to Eclipse Temurin and won't be updated anymore. It is highly recommended to migrate workflows from adopt to temurin to keep receiving software and security updates. See more details in the [Good-bye AdoptOpenJDK post](https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/).) This PR changes GitHub Actions to use temurin instead of adopt as highly recommended above. It also updates acceptance_test to use actions/setup-java@v2 instead of actions/setup-java@v1 to be consistent with the other GitHub Actions.
Contributor
|
Thank you for this contribution! 🍰✨🦄 Information about source corruption0 out of 1248 sources are corrupted. Acceptance test detailsThe changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
https://github.com/actions/setup-java#supported-distributions says:
This PR changes GitHub Actions to use temurin instead of adopt as highly recommended above.
It also updates acceptance_test to use
actions/setup-java@v2instead ofactions/setup-java@v1to be consistent with the other GitHub Actions.Expected behavior:
Use temurin Java distribution on CI instead of adopt, use
actions/setup-java@v2consistently.Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything