test: SystemStubs instead of SystemLambda#1092
test: SystemStubs instead of SystemLambda#1092maximearmstrong merged 6 commits intoMobilityData:masterfrom
Conversation
|
|
|
Tests run fine for me now. Aside: CLA bot seems like it got confused. I haven't un-signed the CLA or anything. |
We had to reconfigure the CLA assistant, this is normal. Could you sign the CLA again? |
|
OK |
|
@ed-g We have configured the repository so that a branch is up to date with |
maximearmstrong
left a comment
maximearmstrong
left a comment
There was a problem hiding this comment.
LGTM, thank you for this contribution @ed-g!
| implementation 'com.beust:jcommander:1.48' | ||
| implementation 'com.google.code.gson:gson:2.8.6' | ||
| implementation 'com.github.stefanbirkner:system-lambda:1.2.0' | ||
| implementation 'uk.org.webcompere:system-stubs-core:2.0.0' |
There was a problem hiding this comment.
Sorry for coming in late here, but if this is just used in tests then I believe this should be testImplementation similar to the below line. Otherwise we're going to be packaging this dependency with the release JAR.
There was a problem hiding this comment.
Looks like latest version is 2.0.1
There was a problem hiding this comment.
Sorry for coming in late here, but if this is just used in tests then I believe this should be
testImplementationsimilar to the below line. Otherwise we're going to be packaging this dependency with the release JAR.
I was not aware of this distinction. I will know for next time :) Everything is fixed in #1140
| @@ -23,6 +23,7 @@ dependencies { | |||
| implementation 'com.beust:jcommander:1.48' | |||
| implementation 'com.google.code.gson:gson:2.8.6' | |||
| implementation 'com.github.stefanbirkner:system-lambda:1.2.0' | |||
There was a problem hiding this comment.
Can dependency on 'com.github.stefanbirkner:system-lambda:1.2.0' be removed now?
There was a problem hiding this comment.
Oh right, I didn't notice. Good catch.
4 participants
Summary:
system stubs for #1086 (comment)