-
Notifications
You must be signed in to change notification settings - Fork 114
Closed
Labels
GTFS Best PracticesUsed for Adding or changing rules that belong in the GTFS Best PracticesUsed for Adding or changing rules that belong in the GTFS Best Practicesgood first issueGood task for newcomers to work on.Good task for newcomers to work on.new ruleNew rule to be addedNew rule to be addedstatus: In review
Description
Including agency_id in routes.txt is a best practice and should generate a warning even though it is not required if there is only one.
Implementatin thoughts:
Rather than returning here in this override, generate a WARNING.
Lines 46 to 59 in 5243445
| public void validate(NoticeContainer noticeContainer) { | |
| if (agencyTable.entityCount() < 2) { | |
| // routes.agency_id is not required when there is a single agency. | |
| return; | |
| } | |
| for (GtfsRoute route : routeTable.getEntities()) { | |
| if (!route.hasAgencyId()) { | |
| noticeContainer.addValidationNotice( | |
| new MissingRequiredFieldNotice( | |
| routeTable.gtfsFilename(), | |
| route.csvRowNumber(), | |
| GtfsRouteTableLoader.AGENCY_ID_FIELD_NAME)); | |
| } | |
| // No need to check reference integrity because it is done by a validator generated from |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
GTFS Best PracticesUsed for Adding or changing rules that belong in the GTFS Best PracticesUsed for Adding or changing rules that belong in the GTFS Best Practicesgood first issueGood task for newcomers to work on.Good task for newcomers to work on.new ruleNew rule to be addedNew rule to be addedstatus: In review
Type
Projects
Status
Done