Skip to content

Test setting threshold of 1.11m on equal_shape_dist_diff_coordinates #1638

@emmambd

Description

@emmambd

Describe the problem

There are recurring concerns that the equal_shape_dist_diff_coordinates error is too sensitive to very small differences between coordinate values. Upon looking at the history of the rule, it was originally proposed to use 1.11m as a threshold between coordinates. There was discussion to set it as an ERROR above 1.11m and a WARNING below 1.11m. At the time when we had fewer feeds in the Mobility Database, this seemed to have minimal value (e.g few feeds were impacted by the threshold change). Now that it's two years later, it's worth testing this with our current feed repository as a starting point to see how many feeds are impacted by it, and propose a more permissive threshold if needed.

Proposed solution

  • Apply a 1.11m threshold to equal_shape_dist_diff_coordinates ERROR (>= 1.11m)
  • Create a WARNING for equal_shape_dist_diff_coordinates( <1.11m)
  • Re-run the acceptance tests to see how many feeds are impacted and what the difference is between coordinates for the feeds affected.

Alternatives you've considered

Additional context

Current rules that have set thresholds, to review logic:

Metadata

Metadata

Assignees

Labels

enhancementNew feature request or improvement on an existing featurestatus: ReadyAn issue that is ready to be worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions