Skip to content

False positives of missing_required_field when encountering empty transfer_type values in transfers.txt #1198

@evansiroky

Description

@evansiroky

Bug report

The GTFS Validator is generating false positives of the missing_required_field when it encounters empty transfers.txt#transfer_type field values.

Describe the bug

Given an empty value within the transfers.txt#transfer_type field (which is valid according to the spec), when the validator checks the file, then it will falsely raise a missing_required_field notice.

How we reproduce the bug

Example feed: Archive.zip

In this feed in the transfers.txt file, the following use case is shown:

from_stop_id,to_stop_id,transfer_type,min_transfer_time
1,2,,

This is a valid use case in that the transfer_type value is empty which indicates a "Recommended transfer point between routes".

Expected behaviour

The validator should not flag this as an error.

Observed behaviour

The GTFS Validator flagged the above-mentioned use case as an error.

Screenshots:

See relevant JSON output for the above-linked feed.

{
  "notices": [{
    "code": "missing_required_field",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [{
      "filename": "transfers.txt",
      "csvRowNumber": 2.0,
      "fieldName": "transfer_type"
    }]
  },
...

Environment versions

  • validator version: v2, v3.0.1, v3.1.0
  • Java version:
  • OS versions:

Metadata

Metadata

Assignees

Labels

GTFS ReferenceUsed for Adding or changing rules that belong in the GTFS referencebugSomething isn't working (crash, a rule has a problem)status: In review

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions