fix: Upgrade to Guava 31 and use ImmutableMap.Builder.buildOrThrow() instead of build() (#1103)

aababilov · web-flow · commit 2b592feb50df · 2022-02-10T11:33:53.000+11:00
ImmutableMap.Builder.build() throws if the same key was added to the builder twice. There were thousands of bugs because many people are not aware of that. The `build()` method is deprecated in Guava 31 and replaced by `buildOrThrow()` with the same behaviour. See also: google/guava@4b9c269
diff --git a/core/build.gradle b/core/build.gradle
@@ -39,7 +39,7 @@ dependencies {
     implementation 'com.univocity:univocity-parsers:2.9.0'
     implementation 'com.google.code.gson:gson:2.8.6'
     implementation 'com.google.geometry:s2-geometry:2.0.0'
-    implementation 'com.google.guava:guava:29.0-jre'
+    implementation 'com.google.guava:guava:31.0.1-jre'
     implementation 'commons-validator:commons-validator:1.6'
     implementation 'com.googlecode.libphonenumber:libphonenumber:8.12.13'
     implementation 'com.google.flogger:flogger:0.6'
diff --git a/main/build.gradle b/main/build.gradle
@@ -80,7 +80,7 @@ dependencies {
     implementation 'com.beust:jcommander:1.48'
     implementation 'javax.inject:javax.inject:1'
     implementation 'com.google.code.gson:gson:2.8.6'
-    implementation 'com.google.guava:guava:29.0-jre'
+    implementation 'com.google.guava:guava:31.0.1-jre'
     implementation 'com.google.flogger:flogger:0.6'
     implementation 'com.google.flogger:flogger-system-backend:0.6'
     implementation 'com.univocity:univocity-parsers:2.9.0'
diff --git a/output-comparator/build.gradle b/output-comparator/build.gradle
@@ -17,7 +17,7 @@ dependencies {
     implementation project(':core')
     implementation 'commons-io:commons-io:2.8.0'
     implementation 'com.google.api-client:google-api-client:1.31.2'
-    implementation 'com.google.guava:guava:29.0-jre'
+    implementation 'com.google.guava:guava:31.0.1-jre'
     implementation 'com.google.flogger:flogger:0.5.1'
     implementation 'com.google.flogger:flogger-system-backend:0.5.1'
     implementation 'com.beust:jcommander:1.48'
diff --git a/processor/build.gradle b/processor/build.gradle
@@ -20,7 +20,7 @@ dependencies {
     implementation 'javax.inject:javax.inject:1'
     implementation 'com.squareup:javapoet:1.13.0'
     implementation 'org.apache.commons:commons-lang3:3.6'
-    implementation 'com.google.guava:guava:29.0-jre'
+    implementation 'com.google.guava:guava:31.0.1-jre'
     implementation 'com.google.flogger:flogger:0.6'
     implementation 'com.univocity:univocity-parsers:2.9.0'
     implementation 'com.google.geometry:s2-geometry:2.0.0'
diff --git a/processor/src/main/java/org/mobilitydata/gtfsvalidator/processor/GtfsFileDescriptor.java b/processor/src/main/java/org/mobilitydata/gtfsvalidator/processor/GtfsFileDescriptor.java
@@ -105,7 +105,7 @@ public GtfsFileDescriptor build() {
           indicesBuilder.add(field);
         }
       }
-      ImmutableMap<String, GtfsFieldDescriptor> fieldsMap = fieldsMapBuilder.build();
+      ImmutableMap<String, GtfsFieldDescriptor> fieldsMap = fieldsMapBuilder.buildOrThrow();
       ImmutableList.Builder<LatLonDescriptor> latLonBuilder = ImmutableList.builder();
       for (GtfsFieldDescriptor field : fields()) {
         if (!field.type().equals(FieldTypeEnum.LATITUDE)) {

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public GtfsFileDescriptor build() {`
`105`	`105`	`indicesBuilder.add(field);`
`106`	`106`	`}`
`107`	`107`	`}`
`108`		`- ImmutableMap<String, GtfsFieldDescriptor> fieldsMap = fieldsMapBuilder.build();`
	`108`	`+ ImmutableMap<String, GtfsFieldDescriptor> fieldsMap = fieldsMapBuilder.buildOrThrow();`
`109`	`109`	`ImmutableList.Builder<LatLonDescriptor> latLonBuilder = ImmutableList.builder();`
`110`	`110`	`for (GtfsFieldDescriptor field : fields()) {`
`111`	`111`	`if (!field.type().equals(FieldTypeEnum.LATITUDE)) {`