chore: provide sample usage of SeverityLevel.WARNING

lionel-nj · lionel-nj · commit 156ccf543f92 · 2021-02-03T15:05:55.000-04:00
diff --git a/main/src/main/java/org/mobilitydata/gtfsvalidator/notice/MissingTripEdgeNotice.java b/main/src/main/java/org/mobilitydata/gtfsvalidator/notice/MissingTripEdgeNotice.java
@@ -29,6 +29,21 @@ public MissingTripEdgeNotice(
             "specifiedField", specifiedField));
   }
 
+  public MissingTripEdgeNotice(
+      long csvRowNumber,
+      int stopSequence,
+      String tripId,
+      String specifiedField,
+      SeverityLevel severityLevel) {
+    super(
+        ImmutableMap.of(
+            "csvRowNumber", csvRowNumber,
+            "stopSequence", stopSequence,
+            "tripId", tripId,
+            "specifiedField", specifiedField),
+        severityLevel);
+  }
+
   @Override
   public String getCode() {
     return "missing_trip_edge_arrival_time_departure_time";
diff --git a/main/src/main/java/org/mobilitydata/gtfsvalidator/notice/RouteShortNameTooLongNotice.java b/main/src/main/java/org/mobilitydata/gtfsvalidator/notice/RouteShortNameTooLongNotice.java
@@ -28,8 +28,7 @@ public RouteShortNameTooLongNotice(String routeId, long csvRowNumber, String rou
         ImmutableMap.of(
             "routeId", routeId,
             "csvRowNumber", csvRowNumber,
-            "routeShortName", routeShortName),
-        SeverityLevel.WARNING);
+            "routeShortName", routeShortName));
   }
 
   @Override
diff --git a/main/src/main/java/org/mobilitydata/gtfsvalidator/validator/MissingTripEdgeValidator.java b/main/src/main/java/org/mobilitydata/gtfsvalidator/validator/MissingTripEdgeValidator.java
@@ -21,6 +21,7 @@
 import org.mobilitydata.gtfsvalidator.annotation.Inject;
 import org.mobilitydata.gtfsvalidator.notice.MissingTripEdgeNotice;
 import org.mobilitydata.gtfsvalidator.notice.NoticeContainer;
+import org.mobilitydata.gtfsvalidator.notice.SeverityLevel;
 import org.mobilitydata.gtfsvalidator.table.GtfsStopTime;
 import org.mobilitydata.gtfsvalidator.table.GtfsStopTimeTableContainer;
 import org.mobilitydata.gtfsvalidator.table.GtfsTripTableContainer;
@@ -62,7 +63,8 @@ public void validate(NoticeContainer noticeContainer) {
                         tripFirstStop.csvRowNumber(),
                         tripFirstStop.stopSequence(),
                         trip.tripId(),
-                        "departure_time"));
+                        "departure_time",
+                        SeverityLevel.WARNING));
               }
               if (!tripLastStop.hasArrivalTime()) {
                 noticeContainer.addValidationNotice(
@@ -78,7 +80,8 @@ public void validate(NoticeContainer noticeContainer) {
                         tripLastStop.csvRowNumber(),
                         tripLastStop.stopSequence(),
                         trip.tripId(),
-                        "departure_time"));
+                        "departure_time",
+                        SeverityLevel.WARNING));
               }
             });
   }
diff --git a/main/src/main/java/org/mobilitydata/gtfsvalidator/validator/RouteNameValidator.java b/main/src/main/java/org/mobilitydata/gtfsvalidator/validator/RouteNameValidator.java
@@ -22,7 +22,6 @@
 import org.mobilitydata.gtfsvalidator.notice.RouteShortAndLongNameEqualNotice;
 import org.mobilitydata.gtfsvalidator.notice.RouteShortNameTooLongNotice;
 import org.mobilitydata.gtfsvalidator.notice.SameNameAndDescriptionForRouteNotice;
-import org.mobilitydata.gtfsvalidator.notice.SeverityLevel;
 import org.mobilitydata.gtfsvalidator.table.GtfsRoute;
 
 /**
diff --git a/main/src/test/java/org/mobilitydata/gtfsvalidator/validator/MissingTripEdgeValidatorTest.java b/main/src/test/java/org/mobilitydata/gtfsvalidator/validator/MissingTripEdgeValidatorTest.java
@@ -23,6 +23,7 @@
 import org.junit.Test;
 import org.mobilitydata.gtfsvalidator.notice.MissingTripEdgeNotice;
 import org.mobilitydata.gtfsvalidator.notice.NoticeContainer;
+import org.mobilitydata.gtfsvalidator.notice.SeverityLevel;
 import org.mobilitydata.gtfsvalidator.table.GtfsStopTime;
 import org.mobilitydata.gtfsvalidator.table.GtfsStopTimeTableContainer;
 import org.mobilitydata.gtfsvalidator.table.GtfsTrip;
@@ -112,7 +113,9 @@ public void tripWithFirstStopMissingDepartureTimeShouldGenerateNotice() {
     underTest.validate(noticeContainer);
 
     assertThat(noticeContainer.getValidationNotices())
-        .containsExactly(new MissingTripEdgeNotice(2, 1, "trip id value", "departure_time"));
+        .containsExactly(
+            new MissingTripEdgeNotice(
+                2, 1, "trip id value", "departure_time", SeverityLevel.WARNING));
   }
 
   @Test
@@ -169,7 +172,9 @@ public void tripWithLastStopMissingDepartureTimeShouldGenerateNotices() {
     underTest.validate(noticeContainer);
 
     assertThat(noticeContainer.getValidationNotices())
-        .containsExactly(new MissingTripEdgeNotice(10, 5, "trip id value", "departure_time"));
+        .containsExactly(
+            new MissingTripEdgeNotice(
+                10, 5, "trip id value", "departure_time", SeverityLevel.WARNING));
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,7 @@ public RouteShortNameTooLongNotice(String routeId, long csvRowNumber, String rou`
`28`	`28`	`ImmutableMap.of(`
`29`	`29`	`"routeId", routeId,`
`30`	`30`	`"csvRowNumber", csvRowNumber,`
`31`		`- "routeShortName", routeShortName),`
`32`		`- SeverityLevel.WARNING);`
	`31`	`+ "routeShortName", routeShortName));`
`33`	`32`	`}`
`34`	`33`
`35`	`34`	`@Override`