set trailing slash optional in route matching#3025
Merged
dead-claudia merged 2 commits intoMay 27, 2025
Conversation
1 task
dead-claudia
requested changes
May 27, 2025
Member
dead-claudia
left a comment
dead-claudia
left a comment
There was a problem hiding this comment.
Looks good to me aside from that nit. I'll turn this into an approval once the suggestion is merged. (I'll try it on my end first.)
|
|
||
| o("remove trailing slash to match route if it is before rest operator match (...) ", function() { | ||
| $window.location.href = prefix + "/test/d/" | ||
| route(root, "/test/:a...", { |
Member
There was a problem hiding this comment.
This isn't a default template, but a default route path. Did you mean to put something else here?
Also, sorry for the delay in reviewing this.
Suggested change
| route(root, "/test/:a...", { | |
| route(root, "/test/some/path", { |
Signed-off-by: Claudia Meadows <[email protected]>
dead-claudia
approved these changes
May 27, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regexp has been updated to set trailing slash as optional in route matching.
Motivation and Context
link to issue 3024.
How Has This Been Tested?
New test has been added. The previous change to keep trailing slash when it match with rest operator is still working.
This is removing the previoous breaking change of always keeping the trailing slash.
Types of changes
Checklist