You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit dab8664
Browse filesBrowse the repository at this point in the historyBrowse files
feat: make public headers consumable as C++20 in compat mode (apache#936)
Enable C++20 consumers to include and use iceberg-cpp’s installed public headers when the library is built with ICEBERG_CXX20_COMPAT=ON, while keeping iceberg-cpp implementation code and internal workflows on C++23. C++23 remains the default public API.
Restore the vendored iceberg::expected backport — brings back src/iceberg/compat/expected.h from apache#40 (removed by [apache#139](apache#139)), with its test and LICENSE entry. unexpected's comparison operators now go through error().
cpp20_compatibility_test compiles all public headers as C++20, and the C++20 example links against an installed compatibility package.
Fixapache#928
Copy file name to clipboardExpand all lines: .github/workflows/cpp-linter.yml
+3-1Lines changed: 3 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -103,6 +103,8 @@ jobs:
103
103
env:
104
104
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
105
105
# need '-fno-builtin-std-forward_like', see https://github.com/llvm/llvm-project/issues/101614
106
+
# cpp20_compatibility_test.cc is ignored: it asserts it is compiled as C++20,
107
+
# which the global '-std=c++23' below would override. The build enforces it.
Copy file name to clipboardExpand all lines: README.md
+13Lines changed: 13 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -39,6 +39,11 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/).
39
39
40
40
- Python 3 and [pre-commit](https://pre-commit.com/) (for linting)
41
41
42
+
Building and developing iceberg-cpp requires C++23. Applications linking against
43
+
an installation built with `ICEBERG_CXX20_COMPAT=ON` may also use C++20 through
44
+
the public-header compatibility layer. See [Using the Library from C++20](mkdocs/docs/getting-started.md#using-the-library-from-c20)
45
+
for its scope.
46
+
42
47
## Quick Start
43
48
44
49
```bash
@@ -104,6 +109,7 @@ cmake --install build
104
109
|`ICEBERG_SQL_MYSQL`|`OFF`| Build the MySQL connector for the SQL catalog |
0 commit comments