[codex] Close EAP-007 performance acceptance#44
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Closes EAP-007 by recording final performance acceptance evidence (tests/benchmarks/gates/smoke timings) and updating the associated planning/task-board documentation, without changing production code.
Changes:
- Adds the EAP-007 closeout packet under
workspace/EAP-007/(plan/strategy/review/verification evidence). - Updates the performance optimization plan with final acceptance results and the EAP-004/EAP-006 residual-risk decision.
- Marks EAP-007 as done in the task-board plan and appends the closeout timeline entries.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| workspace/EAP-007/verification.md | Records verification commands, benchmark outputs, gate results, and built-binary smoke/timing evidence. |
| workspace/EAP-007/test_strategy.md | Documents the focused checks, benchmarks, repo gates, and smoke commands used for acceptance. |
| workspace/EAP-007/review.md | Captures the independent review statement for the closeout packet. |
| workspace/EAP-007/original_impl.md | Summarizes the pre-existing optimized path and baseline evidence/risk framing. |
| workspace/EAP-007/new_impl.md | Defines the proposed acceptance workflow and documentation update plan. |
| workspace/EAP-007/final_impl_v1.md | Finalizes the acceptance/verification plan and interpretation criteria. |
| workspace/EAP-007/final_impl.md | Points to the approved final plan and consolidates reviewer fixes. |
| docs/plans/2026-04-17-event-aggregation-performance-optimization.md | Adds the “Final Acceptance Evidence” section with timings and verification summary. |
| docs/plans/2026-04-17-event-aggregation-performance-optimization-task.md | Updates EAP-007 row to done and appends detailed timeline entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Miss-you
force-pushed
the
codex/eap-007-final-acceptance
branch
3 times, most recently
from
April 17, 2026 09:04
ca05c8e to
b8bcece
Compare
- record EAP-007 verification, timing, and review evidence - mark final EAP acceptance done after EAP-004 and EAP-006 landed
Miss-you
force-pushed
the
codex/eap-007-final-acceptance
branch
from
April 17, 2026 09:08
b8bcece to
fd82952
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dailymedian 0.51s versus the recorded 5.07s/5.26s baseline.Verification
go test ./cmd -run 'Test(CollectUsageEventsFromProviders|RunDaily|RunSession|ResolveDailyDateRange|ResolveSession|AggregateDailyUsageEventsFromProvidersInRange)' -count=1go test ./provider/claude ./provider/codex ./provider/kimi ./provider/cursor -run 'Test.*UsageEventsInRange|TestCollectClaudeUsageEventsWithParser_ParsesInParallelAndSorts|TestParseCodexUsageEvents' -count=1go test ./stats -run 'Test(FilterEventsByDateRange|AggregateEventsByDayWithDimension|DailyEventAggregator)' -count=1go test ./e2e -run TestEventBasedCrossDayAcceptance -count=1go test ./provider/claude -run '^$' -bench 'BenchmarkCollectClaudeUsageEventsSynthetic$' -count=1go test ./provider/codex -run '^$' -bench 'BenchmarkParseCodexUsageEventsSynthetic$' -count=1go test ./cmd -run '^$' -bench 'BenchmarkDailyAggregationMaterializedVsStreaming$' -benchmem -count=1make fmtgo clean -testcache && make testmake vetmake lintmake builddaily,daily --json,daily --all --json,daily --provider claude --json,session --json, andsession --since 2026-04-15 --until 2026-04-16 --json.