[codex] Merge event aggregation performance baseline and Codex parser optimization#42
Conversation
- replace generic model-map extraction with targeted JSON field scanning - preserve Codex model fallback precedence and skipped-token model propagation - add parser hot-path allocation guards and synthetic Codex benchmark
There was a problem hiding this comment.
Pull request overview
This PR merges the Codex event aggregation performance baseline work and the Codex parser optimization stack into main, adding correctness/performance guardrails while reducing Codex JSON parsing churn on hot paths.
Changes:
- Optimize Codex model extraction by replacing generic JSON unmarshalling/path-walking with typed fields plus a lightweight JSON field scanner.
- Expand Codex parser test coverage for model propagation/fallback scenarios and add allocation/benchmark guardrails.
- Update the event aggregation performance task board to reflect completion of EAP-005.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| provider/codex/parser.go | Refactors Codex model extraction and model propagation logic to reduce allocations/CPU. |
| provider/codex/parser_test.go | Adds additional model-fallback correctness tests plus allocation budgets and a synthetic benchmark. |
| docs/plans/2026-04-17-event-aggregation-performance-optimization-task.md | Marks EAP-005 as done and records change log entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6059ff8eb6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # docs/plans/2026-04-17-event-aggregation-performance-optimization-task.md # provider/codex/parser_test.go
|
Addressed the AI review threads in
Verification run after the fix:
|
Summary
Validation
make fmtgo clean -testcache && make testmake vetmake buildmake lintNotes
This PR merges the completed
codex/eap-001-baselinestack intomain.