test: add EBTA-009 cross-day e2e acceptance#35
Merged
Conversation
- add isolated Codex, Claude, and Kimi cross-day fixtures - assert daily UTC splits and session UTC in-range totals - close EBTA-009 with workspace verification and review notes
There was a problem hiding this comment.
Pull request overview
Adds end-to-end acceptance coverage ensuring event-based aggregation correctly splits a single provider session across a UTC midnight boundary and filters session totals by in-range event dates, without perturbing existing e2e fixtures.
Changes:
- Introduces isolated cross-day fixtures for Codex (cumulative totals), Claude (assistant usage), and Kimi (StatusUpdate token usage) under
e2e/testdata/cross-day/. - Adds
TestEventBasedCrossDayAcceptancecoveringdaily --json(split by event date) andsession --json(in-range-only totals) with--timezone UTC. - Updates the event-based aggregation plan/task docs and adds workspace notes (strategy, verification, review) for EBTA-009.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
e2e/e2e_test.go |
Adds cross-day fixture path helpers and a focused e2e acceptance test validating daily/session JSON behavior across UTC midnight. |
e2e/testdata/cross-day/codex/2026/04/15/rollout-2026-04-15T23-50-00-cross-day.jsonl |
Adds a Codex rollout fixture with cumulative total_token_usage spanning 2026-04-15/16 UTC. |
e2e/testdata/cross-day/claude/project-cross-day/cross-day.jsonl |
Adds a Claude JSONL fixture with assistant usage on both sides of midnight. |
e2e/testdata/cross-day/kimi/hash-cross-day/session-cross-day/metadata.json |
Adds Kimi session metadata for the cross-day fixture. |
e2e/testdata/cross-day/kimi/hash-cross-day/session-cross-day/wire.jsonl |
Adds Kimi wire events with token_usage updates straddling midnight (Unix timestamps). |
docs/plans/2026-04-16-event-based-token-aggregation-task.md |
Marks EBTA-009 as done and records verification/review evidence. |
workspace/EBTA-009/verification.md |
Captures command/test gate results used to verify EBTA-009. |
workspace/EBTA-009/test_strategy.md |
Documents red/green test strategy and expected JSON totals/rows. |
workspace/EBTA-009/review.md |
Records independent review scope and verification command. |
workspace/EBTA-009/original_impl.md |
Notes why the change is acceptance-only and why fixtures must be isolated. |
workspace/EBTA-009/new_impl.md |
Describes the candidate acceptance-only approach and assertions. |
workspace/EBTA-009/final_impl_v1.md |
Specifies fixture expectations and implementation notes for the final approach. |
workspace/EBTA-009/final_impl.md |
Declares final accepted scope (e2e fixtures + assertions only). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e/testdata/cross-day/daily --json --since 2026-04-15 --until 2026-04-16 --timezone UTCsession --json --since 2026-04-16 --until 2026-04-16 --timezone UTCVerification
go test -count=1 ./e2e -run TestEventBasedCrossDayAcceptancego test -count=1 ./e2e -run Testmake fmtmake testmake vetmake buildmake lintReview